This repository has been archived by the owner on Mar 25, 2020. It is now read-only.
Ports /tg/ random View Variables crash fix #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might not be a bad idea to add a comment about why, so noone removes the "useless" sleep. |
|
Good idea, I thought it wasn't necessary, but I guess it's better safe than sorry. This will only be an issue until we finish the rebase (as this is included there). Consider this a temporary fix. |
|
Outdone yourself with this port Dark. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent of your Pull Request
Sometimes, View Variables seems to crash the client. Hopefully, this fixes that.
Credit to @lordpidey and his PR:tgstation/tgstation#18334