Add missing domain id value in subscan #1069
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1041
In database there is a lot of endpoints which does not have a target_domain_id value.
![image](https://private-user-images.githubusercontent.com/1230954/285062213-f1a5c950-8105-427b-b67e-5443bf7b6095.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NTMxMDcsIm5iZiI6MTczOTU1MjgwNywicGF0aCI6Ii8xMjMwOTU0LzI4NTA2MjIxMy1mMWE1Yzk1MC04MTA1LTQyN2ItYjY3ZS01NDQzYmY3YjYwOTUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTRUMTcwNjQ3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YTc1MTE3OGFiNDVhMmJkMGNmMmFkMDFhNGRmYWQxNTM4MmQ0MDEwMzcxNWQzOTg1NzczMjA2YTJhZGEwMjYwNyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.Qp6fG_oCX6MnocFdLpa95G27Xp5eUuw9t4NgExrWEpY)
It generates a lot of duplicates and can cause scan to fail, bad count (see #1041) and a lot of side effects
This PR fix missing domain_id value while launching a subscan
This fix definitively #1040
For those who wants to correctly count their endpoints previously scanned on target page, you need to update the target id of endpoints in the database