Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrating thumbnails #99

Merged
merged 12 commits into from
May 29, 2024
Merged

Integrating thumbnails #99

merged 12 commits into from
May 29, 2024
+176 −101

Conversation

jakubjezek001
Copy link
Member

@jakubjezek001 jakubjezek001 commented May 21, 2024 •
edited
Loading

Thumbnails now come from the thumbnailPath in the instance data. This solves the issue when video or image sequences aren't published, but a thumbnail is still there.

Testing steps

  1. create and install addon package to your server
  2. reboot server
  3. create new bundle and include the verison of shotgrid into it. mark it as production bundle
  4. copy or define your settings to be pointing to our sg server with all secrets and others.. (contact me for help)
  5. go to Extract review preset settings and tag shotgridreview any of output presets
  6. start Ayon Desktop app and publish version from Nuke/Maya/traypublisher
  7. publish ideally image sequence data
  8. but also publish geometry product and screenshot thumbnail via publisher widget.
  9. See that the version with thumbnail was publised

@ynbot
Copy link
Contributor

ynbot commented May 21, 2024

Task linked: AY-5528 Shotgrid: publishing screengrub thumbnails

@jakubjezek001 jakubjezek001 added the type: bug Something isn't working label May 21, 2024
@jakubjezek001
Bump version numbers to 0.4.2-dev.2 across packages.
36f468f 
Updated version numbers in multiple files to 0.4.2-dev.2 for shotgrid integration services and package metadata.
@64qam 64qam requested a review from MilaKudr May 22, 2024 10:49
@jakubjezek001 jakubjezek001 mentioned this pull request May 22, 2024
Merged
@jakubjezek001 jakubjezek001 requested a review from iLLiCiTiT May 29, 2024 14:40
iLLiCiTiT
iLLiCiTiT reviewed May 29, 2024
View reviewed changes
client/ayon_shotgrid/plugins/publish/integrate_shotgrid_publish.py Outdated
Comment on lines 219 to 222
sg_published_file["type"],
sg_published_file["id"],
published_file_data,
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sg_published_file["type"],
sg_published_file["id"],
published_file_data,
)
sg_published_file["type"],
sg_published_file["id"],
published_file_data,
)

iLLiCiTiT
iLLiCiTiT approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@iLLiCiTiT iLLiCiTiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakubjezek001 jakubjezek001 merged commit d4fc4bb into develop May 29, 2024
@jakubjezek001 jakubjezek001 deleted the bugfix/AY-5528_Shotgrid-publishing-screengrub-thumbnails branch May 29, 2024 15:27
m-u-r-p-h-y
m-u-r-p-h-y approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thumbnails created and uploaded successfully

  • from screengrab
  • from mp4

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iLLiCiTiT iLLiCiTiT iLLiCiTiT approved these changes

@m-u-r-p-h-y m-u-r-p-h-y m-u-r-p-h-y approved these changes

@64qam 64qam Awaiting requested review from 64qam

@MilaKudr MilaKudr Awaiting requested review from MilaKudr

Assignees

@64qam 64qam

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jakubjezek001 @ynbot @m-u-r-p-h-y @iLLiCiTiT @64qam