Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typos and code style improvements #77

Merged
merged 6 commits into from
Apr 2, 2024
Merged

Typos and code style improvements #77

merged 6 commits into from
Apr 2, 2024
+256 −178

Conversation

jakubjezek001
Copy link
Member

@jakubjezek001 jakubjezek001 commented Mar 29, 2024 •
edited
Loading

There is a lot of changes but most of them are about improving code style and typos.

Also as you can see I am pushing the ShotGrid namespace rather then Shotgrid. It looks nicer but this is really just my opinion ;)

@m-u-r-p-h-y
Copy link
Member

you should change it to Flow now ;-)

@fabiaserra
Copy link
Contributor

please don't try merge this PR until the bigger PRs #72, #79 are merged. And like @m-u-r-p-h-y said, if anything we should update to Flow now

iLLiCiTiT
iLLiCiTiT approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@iLLiCiTiT iLLiCiTiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some smaller comments about AYON naming.

iLLiCiTiT
iLLiCiTiT reviewed Apr 2, 2024
View reviewed changes
server/__init__.py Outdated Show resolved Hide resolved
@jakubjezek001
Copy link
Member Author

We are not planning to rename it any time soon to Flow

jakubjezek001 and others added 2 commits April 2, 2024 17:06
@jakubjezek001 jakubjezek001 merged commit da58c44 into feature/OP-8075_shotgrid_settings_for_mapping_custom_attributes Apr 2, 2024
@fabiaserra
Copy link
Contributor

I don't get why did you merge this? Didn't I ask yesterday to please hold on this until the bigger PRs are merged? now it makes this pending PR #79 harder to merge and #72 contains a lot of things not specific to those changes

@fabiaserra fabiaserra mentioned this pull request Apr 9, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iLLiCiTiT iLLiCiTiT iLLiCiTiT approved these changes

@fabiaserra fabiaserra fabiaserra left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jakubjezek001 @m-u-r-p-h-y @fabiaserra @iLLiCiTiT