-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/kitsu to ayon name conversions #55
Enhancement/kitsu to ayon name conversions #55
Conversation
… - fixes username bugs. Tests added.
server/kitsu/push.py
Outdated
|
||
username = remove_accents( | ||
f"{entity_dict['first_name']}.{entity_dict['last_name']}".lower().strip() | ||
logging.info( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we store the first and last name to variables? There is a lot entity_dict['first_name']
and entity_dict['last_name']
everywhere. Also some are using .get(
and some are directly expecting the key to be there, are the values always filled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, addressed in ef114ae
Co-authored-by: Jakub Trllo <[email protected]>
Co-authored-by: Jakub Trllo <[email protected]>
I looked at slugify but it seems to be more restrictive than the AYON validation which allows capitals, hyphens and dots.
I need to use capitalised project codes and short names for our naming convention so I would suggest the addon does not convert to lower and be overly restrictive unless it has to be. |
…tsu entity. Method can be used for other entity checks
Allows Kitsu names to be converted to a valid Ayon name.
for tests: