Make the JIT module stand alone. #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltratt
reviewed
Feb 21, 2024
| @@ -630,14 +700,36 @@ impl Module { | |||
| ExtraArgsIdx::new(idx) | |||
| } | |||
|
|
|||
| /// Push a new type into the type table and return its index. | |||
| fn push_type(&mut self, ty: Type) -> Result<TypeIdx, CompilationError> { | |||
There was a problem hiding this comment.
I now realise that you've effectively implemented https://crates.io/crates/indexmap. No need to fix it in this PR but might be worth considering for an upcoming PR?
There was a problem hiding this comment.
Ah yes. I vaguely remember this from our rustc days.
And it looks like it does the key parameterisation too, so perhaps all TiVecs should in fact be IndexMaps?
One for a future PR, yes.
|
Any further comments on this, or ready to go? |
ptersilie
reviewed
Feb 21, 2024
ptersilie
reviewed
Feb 21, 2024
ptersilie
reviewed
Feb 21, 2024
|
Please squash. |
Before, the JIT module would share types, globals and functions with the AOT module. While efficient, it makes testing conceptually more complex. This change makes the JIT IR stand alone.
|
splat. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the JIT module would share types, globals and functions with the AOT module. While efficient, it makes testing conceptually more complex.
This change makes the JIT IR stand alone.