Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle some more opcodes. #965

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Handle some more opcodes. #965

merged 3 commits into from
Feb 13, 2024

Conversation

ptersilie
Copy link
Contributor

No description provided.

@ltratt
Copy link
Contributor

ltratt commented Feb 8, 2024

Does https://ykjit.github.io/yk/internals/ir.html need updating?

@vext01
Copy link
Contributor

vext01 commented Feb 8, 2024

Does https://ykjit.github.io/yk/internals/ir.html need updating?

We probably should.

(A little niggle in my head wonders if that page is worthwhile -- I don't know if others have thoughts?)

@ptersilie
Copy link
Contributor Author

That entire document is out of date isn't it. I feel like keeping it around would mean we would constantly have to update it as I imagine this isn't the last time our design changes.

@ltratt
Copy link
Contributor

ltratt commented Feb 8, 2024

OK I'll raise a PR to kill it.

@vext01
Copy link
Contributor

vext01 commented Feb 8, 2024

I think I'm OK with this. It seems doomed to be out of date.

@ltratt
Copy link
Contributor

ltratt commented Feb 9, 2024

@ptersilie I assume this needs an updated ykllvm submodule?

@vext01
Copy link
Contributor

vext01 commented Feb 9, 2024

Can we get this in?

@ltratt
Copy link
Contributor

ltratt commented Feb 9, 2024

I'm still waiting for a response to my comment about the ykllvm submodule.

@ptersilie
Copy link
Contributor Author

Ah yes it does. Will update later today.

@ptersilie
Copy link
Contributor Author

Updated the submodule. This should be ready for merging now.

@ltratt
Copy link
Contributor

ltratt commented Feb 12, 2024

Please squash.

@ptersilie
Copy link
Contributor Author

Squashed.

@ltratt ltratt added this pull request to the merge queue Feb 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 12, 2024
@ptersilie
Copy link
Contributor Author

That should get rid of those warnings.

@ltratt
Copy link
Contributor

ltratt commented Feb 12, 2024

Please squash.

@ptersilie
Copy link
Contributor Author

Squashed.

@ltratt ltratt added this pull request to the merge queue Feb 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 12, 2024
@ptersilie
Copy link
Contributor Author

Huh. For some reason the call instruction size test fails, even though I haven't even touched call instructions. Investigating.

@ptersilie
Copy link
Contributor Author

I should really run the tests before pushing a PR. 🤦

Ok to squash?

@ltratt
Copy link
Contributor

ltratt commented Feb 13, 2024

Please squash.

ptersilie and others added 3 commits February 13, 2024 11:59
Co-authored-by: Edd Barrett <[email protected]>
There appear two be only two instructions involving globals: store and load. So
instead of hiding globals inside constants, like LLVM does, store them in a
separate vector and add two special opcodes StoreGlobal and LoadGlobal.
@ptersilie
Copy link
Contributor Author

Squashed.

@ltratt ltratt added this pull request to the merge queue Feb 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 13, 2024
@ptersilie
Copy link
Contributor Author

12:31:38   --- stderr
12:31:38   thread 'main' panicked at ykbuild/src/completion_wrapper.rs:100:25:
12:31:38   source file has no extension: '--version', buf='/ci/ykllvm/build/../inst/bin/clang --version'

I have no idea what this is.

@ltratt ltratt added this pull request to the merge queue Feb 13, 2024
Merged via the queue into ykjit:master with commit a3d1db3 Feb 13, 2024
2 checks passed
@ptersilie ptersilie deleted the more-bytecode2 branch February 26, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants