-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle some more opcodes. #965
Conversation
Does https://ykjit.github.io/yk/internals/ir.html need updating? |
We probably should. (A little niggle in my head wonders if that page is worthwhile -- I don't know if others have thoughts?) |
That entire document is out of date isn't it. I feel like keeping it around would mean we would constantly have to update it as I imagine this isn't the last time our design changes. |
OK I'll raise a PR to kill it. |
I think I'm OK with this. It seems doomed to be out of date. |
@ptersilie I assume this needs an updated ykllvm submodule? |
Can we get this in? |
I'm still waiting for a response to my comment about the ykllvm submodule. |
Ah yes it does. Will update later today. |
Updated the submodule. This should be ready for merging now. |
Please squash. |
b408d72
to
13fc8ec
Compare
Squashed. |
That should get rid of those warnings. |
Please squash. |
eaebec7
to
e9f4c62
Compare
Squashed. |
Huh. For some reason the call instruction size test fails, even though I haven't even touched call instructions. Investigating. |
I should really run the tests before pushing a PR. 🤦 Ok to squash? |
Please squash. |
Co-authored-by: Edd Barrett <[email protected]>
There appear two be only two instructions involving globals: store and load. So instead of hiding globals inside constants, like LLVM does, store them in a separate vector and add two special opcodes StoreGlobal and LoadGlobal.
73566fe
to
6b8b1bb
Compare
Squashed. |
I have no idea what this is. |
No description provided.