bb = usize::MAX isn't a special value.
#964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At some point in the past `bb = usize::MAX` was used to represent "unmappable" but it's now a separate `enum` item. Nowhere in yk seems to check/set `bb` for/to `usize::MAX` so this commit removes the (hopefully) misleading comment. In case we're wrong, I've left behind an `assert` that's likely to catch any old code. One day far in the future our successors might feel confident enough to remove the `assert`!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point in the past
bb = usize::MAXwas used to represent "unmappable" but it's now a separateenumitem. Nowhere in yk seems to check/setbbfor/tousize::MAXso this commit removes the (hopefully) misleading comment. In case we're wrong, I've left behind anassertthat's likely to catch any old code. One day far in the future our successors might feel confident enough to remove theassert!