Pass [AOT]TraceIterator to compiler backends
#961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the JIT compilers, if they so choose, to iterate over the blocks. If a tracer chooses to process (e.g. decode) its trace in a thread, this means that (some of) compilation and trace processing can occur in parallel. At the moment, this commit doesn't change anything meaningful inside jitc_ykllvm or jitc_yk: both immediately `collect` the iterator into a `Vec`. But the API is now flexible enough to allow something better in the future.
Since we have more than one type of "trace", it's easy to get confused when reading the code as to which one is looking at. Since `TraceIterator` returns `TracedAOTBlock`, renaming the iterator to `AOTTraceIterator` seems sensible.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows compiler backends to obtain AOT blocks one-by-one, potentially allowing tracers to put trace process (e.g. hwt decoding) in a thread (c8ea235). That made me realise that
TraceIteratoris a slightly suboptimal name so I've suggested changing it toAOTTraceIterator(1ea1014).