Don't give up on a location the first time compiling fails. #1567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vext01
reviewed
Jan 27, 2025
vext01
reviewed
Jan 27, 2025
|
OK to squash? |
|
Oh yeah, sorry. Please go ahead. |
ltratt
force-pushed
the
dont_get_stuck_on_first_miscompile
branch
from
2a32832 to
a587225
Compare
|
Squashed. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This comment in the code was partly wrong: ``` // FIXME: We will endless retry tracing this // [HotLocation]. There should be a `Counting` // state. ``` In fact, we wouldn't endlessly retry: the `HotLocation` would get stuck in the `Compiling` state. Still, the end effect was the same as the comment suggested! This commit allows `HotLocation`s to transition back to the `Counting` state so that we can retry. That requires allowing `HotLocations` to also be in the `Counting` state: in other words, we can "count" both with and without a `HotLocation`.
ltratt
force-pushed
the
dont_get_stuck_on_first_miscompile
branch
from
a587225 to
153ccbb
Compare
|
Force pushed Clippy fixes (oops). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment in the code was partly wrong:
In fact, we wouldn't endlessly retry: the
HotLocationwould get stuck in theCompilingstate. Still, the end effect was the same as the comment suggested!This commit allows
HotLocations to transition back to theCountingstate so that we can retry. That requires allowingHotLocationsto also be in theCountingstate: in other words, we can "count" both with and without aHotLocation.