Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iced_x86 has asan warnings. #981

Closed
vext01 opened this issue Feb 21, 2024 · 1 comment
Closed

iced_x86 has asan warnings. #981

vext01 opened this issue Feb 21, 2024 · 1 comment
Assignees
@vext01

Comments

@vext01
Copy link
Contributor

vext01 commented Feb 21, 2024

The branch I'm about to merge in #971 causes asan warnings in the iced_x86 crate dep.

I'm going to comment out asan for now. Raising this to remind us.
@vext01 vext01 self-assigned this Feb 21, 2024
vext01 added a commit to vext01/yk_pv that referenced this issue Feb 21, 2024
@vext01
Disable asan for now.
789570f 
ykjit#981
@vext01 vext01 mentioned this issue Feb 21, 2024
Merged
vext01 added a commit to vext01/yk_pv that referenced this issue Feb 21, 2024
@vext01
New codegen backend: Start emitting code.
8d974eb 
This makes a start at emitting X86_64 code from the JIT IR.

Obviously this is non-functional at this point (it's currently not even
called from the JIT pipeline), but should serve as something we can
iterate upon and at least unit test in isolation.

Many things missing:
 - Trace input handling.
 - Correct allocation sizes.
 - Stackmaps
 - Debugger support.
 - Loads more testing.

Note we disable asan for now:
ykjit#981
@vext01
Copy link
Contributor Author

vext01 commented Feb 26, 2024

This was fixed in #989

(FWIW, iced has recently fixed their warnings too)

@vext01 vext01 closed this as completed Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vext01 vext01

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vext01