feat: add script to retrieve Playwright version and cache binaries in… #59
Conversation
|
Warning Rate limit exceeded@yk-lab has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 29 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughこの変更は、Playwrightのバージョンを取得するための新しいシェルスクリプトを追加し、GitHub Actionsのワークフローに統合するものです。新規スクリプトはJSON形式の依存関係リストから Changes
Sequence Diagram(s)sequenceDiagram
participant Workflow as GitHub Actions Workflow
participant Script as get-playwright-version.sh
participant Depend as 依存関係リスト (JSON)
participant Cache as actions/cache
Workflow->>Script: シェルスクリプト実行
Script->>Depend: 依存関係情報取得
Depend-->>Script: JSONデータ返却
Script->>Script: jqでPlaywrightバージョン抽出
Script->>Workflow: バージョン出力 & Actions出力更新
Workflow->>Cache: Playwrightバイナリのキャッシュ処理
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Deploying pdf-compressor with
|
| Latest commit: |
4b7b39b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ffbdf527.pdf-compressor.pages.dev |
| Branch Preview URL: | https://chore-gha-playwrite-cache.pdf-compressor.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
=======================================
Coverage 15.38% 15.38%
=======================================
Files 9 9
Lines 260 260
Branches 10 6 -4
=======================================
Hits 40 40
Misses 217 217
Partials 3 3 ☔ View full report in Codecov by Sentry. |
|
Diff Coverage: Not applicable. There was no coverage data reported for the files in this diff. Total Coverage: This PR will not change total coverage. 🛟 Help
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/scripts/get-playwright-version.sh (1)
5-8: Playwrightバージョンの取得と出力
pnpm list --depth 1 --jsonとjqを組み合わせて@playwright/testのバージョンを抽出し、出力ファイルに追記する実装は正しく動作すると考えられます。
ただし、万が一バージョン情報が取得できなかった場合のエラーチェックやフォールバック処理を検討すると、より堅牢になる可能性があります。.github/workflows/node.yml (1)
32-38: Playwrightバイナリのキャッシュ設定に関する指摘
「Cache playwright binaries」のステップはCIのパフォーマンス向上に寄与しますが、actions/cache@v2は古いバージョンです。最新の安定版（例:actions/cache@v3）への更新を検討してください。🧰 Tools
🪛 actionlint (1.7.4)
33-33: the runner of "actions/cache@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/scripts/get-playwright-version.sh(1 hunks).github/workflows/node.yml(1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.4)
.github/workflows/node.yml
33-33: the runner of "actions/cache@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: build
- GitHub Check: Cloudflare Pages
🔇 Additional comments (2)
.github/scripts/get-playwright-version.sh (1)
1-4: 初期設定とシェバンの確認
シェバン行とset -euo pipefailにより、エラー時の処理や未定義変数の利用を防止する設定が適切に行われています。.github/workflows/node.yml (1)
29-31: Playwrightバージョン取得ステップの追加確認
「Get installed Playwright version」のステップで、スクリプトを実行しPlaywrightのバージョンを正しく取得できるようになっています。取得された情報が後続のキャッシュキーに利用されるため、結果が正しいか確認してください。
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
yk-lab
force-pushed
the
chore/gha_playwrite_cache
branch
from
131c386 to
4b7b39b
Compare
|
… workflow
Summary by CodeRabbit