Fix PHPStan issues

yireo · Mar 4, 2024 · 156ef96 · 156ef96
1 parent 7947b17
commit 156ef96
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 5 deletions.
diff --git a/Test/Integration/BodyTest.php b/Test/Integration/BodyTest.php
@@ -2,6 +2,8 @@
 
 namespace Yireo\LinkPreload\Test\Integration;
 
+use Magento\Framework\App\Response\Http;
+
 class BodyTest extends AbstractTestCase
 {
     /**
@@ -11,7 +13,9 @@ public function testIfLinkHeadersExistsWhenModuleIsEnabled()
     {
         $this->assertEnabledValue(1);
         $this->dispatch('/');
-        $body = (string)$this->getResponse()->getBody();
+        /** @var Http $response */
+        $response = $this->getResponse();
+        $body = (string)$response->getBody();
         foreach ((new LinkDataProvider())->getLinks() as $link) {
             $this->assertBodyContainsLink($link[0], $link[1], $body);
         }
@@ -31,7 +35,9 @@ public function testIfLinkHeadersExistsWhenModuleIsEnabledAndWithFullPageCache()
 
         $this->assertEnabledValue(1);
         $this->dispatch('/');
-        $body = (string)$this->getResponse()->getBody();
+        /** @var Http $response */
+        $response = $this->getResponse();
+        $body = (string)$response->getBody();
         $this->assertNotEmpty($body);
 
         foreach ((new LinkDataProvider())->getLinks() as $link) {

diff --git a/Test/Integration/HeaderTest.php b/Test/Integration/HeaderTest.php
@@ -5,6 +5,7 @@
 use Magento\Framework\App\Cache\Manager;
 use Magento\Framework\App\Config\ScopeConfigInterface;
 use Laminas\Http\Header\HeaderInterface;
+use Magento\Framework\App\Response\Http;
 
 class HeaderTest extends AbstractTestCase
 {
@@ -41,11 +42,13 @@ public function testIfLinkHeadersExistsWhenModuleIsEnabledAndWithFullPageCache()
 
         $this->getLinkHeaders();
         $this->getLinkHeaders();
-        $allHeaders = $this->getResponse()->getHeaders();
+        /** @var Http $response */
+        $response = $this->getResponse();
+        $allHeaders = $response->getHeaders();
         $this->assertTrue(count($allHeaders) > 0, 'No headers found: '.$allHeaders->toString());
 
         $linkHeaders = $this->getLinkHeaders();
-        $this->assertTrue(count($linkHeaders) > 0, 'No Link-headers found: '.$this->getResponse()->getHeaders()->toString());
+        $this->assertTrue(count($linkHeaders) > 0, 'No Link-headers found: '.$allHeaders->toString());
     }
 
     /**
@@ -61,7 +64,9 @@ public function testIfLinkHeadersExistsWhenModuleIsDisabled()
     private function getLinkHeaders(): array
     {
         $this->dispatch('/');
-        $headers = $this->getResponse()->getHeaders();
+        /** @var Http $response */
+        $response = $this->getResponse();
+        $headers = $response->getHeaders();
 
         $linkHeaders = [];
         foreach ($headers as $header) {