Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add composer command yii-config-info #175

Merged
merged 23 commits into from
Apr 9, 2024
Merged

Add composer command yii-config-info #175

merged 23 commits into from
Apr 9, 2024

Conversation

vjik
Copy link
Member

@vjik vjik commented Apr 7, 2024

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

composer yii-config-info:

image
image

composer yii-config-info yiisoft/widget:

image

@xepozz
Copy link
Member

xepozz commented Apr 7, 2024

Add composer command yii-config-info

What about to use namespace instead?
yii-config:info
yii:config:info
yii:config-info

@vjik
Copy link
Member Author

vjik commented Apr 7, 2024

Add composer command yii-config-info

What about to use namespace instead? yii-config:info yii:config:info yii:config-info

This is not consistent with other exists commands (yii-config-copy, yii-config-rebuild).

@vjik vjik marked this pull request as ready for review April 7, 2024 15:49
@vjik vjik requested a review from a team April 7, 2024 15:52
@vjik vjik added the status:code review The pull request needs review. label Apr 7, 2024
@xepozz
Copy link
Member

xepozz commented Apr 7, 2024

Add composer command yii-config-info

What about to use namespace instead? yii-config:info yii:config:info yii:config-info

This is not consistent with other exists commands (yii-config-copy, yii-config-rebuild).

So we can aliases for them and make them deprecated for the further versions

CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
vjik and others added 2 commits April 9, 2024 21:36
Co-authored-by: Alexander Makarov <[email protected]>
Co-authored-by: Alexander Makarov <[email protected]>
@vjik vjik merged commit 39800f6 into master Apr 9, 2024
20 of 21 checks passed
@vjik vjik deleted the new-command branch April 9, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants