Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify select_read() and select_write() #2047

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

falbrechtskirchinger
Copy link
Contributor

@falbrechtskirchinger falbrechtskirchinger commented Feb 10, 2025

Adds a templated select_imp() function combining select_read() and select_write(). Simplifies future changes by avoiding duplication.

Checklist:

  • Run tests with select().
  • Run tests with poll().

@yhirose yhirose merged commit b397c76 into yhirose:master Feb 10, 2025
4 checks passed
@yhirose
Copy link
Owner

yhirose commented Feb 10, 2025

@falbrechtskirchinger thanks for the good improvement. 👍

@falbrechtskirchinger falbrechtskirchinger deleted the unified-select branch February 11, 2025 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants