Do not use buf.size() on a uninitialized array.
#1085
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent version of gcc raise a warning `maybe-uninitialized` when using `size()` method on a uninitialized array. This prevent us to use httplib in a project compiled with `-Werror`.
|
@mgautierfr, thanks for the feedback, but I don't agree with the warning from gcc. It looks like a false negative to me. I'll google it, and get back to you. EDIT: I just found the gcc bug report "Bug 101831 - Spurious maybe-uninitialized warning on std::array::size". According to it, I am thinking not to merge this pull request, since other compilers don't emit the incorrect warning at this point. But I would appreciate it if you give me your thought. I am still open to this issue. Thanks! |
mgautierfr
added a commit
to kiwix/libkiwix
that referenced
this pull request
Nov 5, 2021
Patch has been send upstream : yhirose/cpp-httplib#1085
mgautierfr
added a commit
to kiwix/libkiwix
that referenced
this pull request
Nov 5, 2021
Patch has been send upstream : yhirose/cpp-httplib#1085
mgautierfr
added a commit
to kiwix/libkiwix
that referenced
this pull request
Nov 8, 2021
Patch has been send upstream : yhirose/cpp-httplib#1085
|
@mgautierfr, I guess i fixed this issue in a better way. Could you check with the latest httplib.h on your machine when you have a chance? Thanks! |
|
It works on my computer yes. Thanks for the fix. |
ExclusiveOrange
pushed a commit
to ExclusiveOrange/cpp-httplib-exor
that referenced
this pull request
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent version of gcc raise a warning
maybe-uninitializedwhen usingsize()method on a uninitialized array.This prevent us to use httplib in a project compiled with
-Werror.This fixes the same problem than #980 but in a better way.
I concentrate myself on the place where gcc raised a warning, not everywhere in the code where we could replace
buf.size()by a constant.