Add LoadingOverlay for Component And Bundle Loading #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshi97
commented
Sep 26, 2023
oshi97
force-pushed
the
dev/loading-overlay
branch
from
6e2b73d to
6c9e14c
Compare
oshi97
changed the title
alextaing
reviewed
Sep 28, 2023
alextaing
reviewed
Sep 28, 2023
alextaing
reviewed
Sep 28, 2023
alextaing
reviewed
Sep 28, 2023
e2e-tests/__screenshots__/darwin/add-element.spec.ts/can-add-a-Footer-component-1.png
Outdated
Show resolved
Hide resolved
alextaing
previously approved these changes
Sep 28, 2023
tmeyer2115
reviewed
Sep 28, 2023
Merged
alextaing
added a commit
that referenced
this pull request
Oct 3, 2023
## Features - We've added a page loading indicator that shows studio startup progress (#388)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the LoadingOverlay components, which will provide a loading screen while user components and
the rest of the application are being loaded over the network.
In the future we can add additional information to this screen regarding hitting the management api and loading
in localData files, if necessary.
J=SLAP-2895
TEST=manual