Update element icons #378
Merged
Update element icons #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextaing
force-pushed
the
dev/element-icons
branch
from
77719f4 to
6a5759b
Compare
|
LGTM once we regenerate the screenshots! |
|
I'm okay not regenerating screenshots if it's not getting picked up automatically - I don't think it's worth spending time manually picking out all the ones that need to be updated. It would be better to spend that time updating the way we take those screenshots to be focused on smaller portions of the page. Eventually this will also let us decrease the minimum pixel change ratio |
oshi97
previously approved these changes
Sep 22, 2023
alextaing
force-pushed
the
dev/element-icons
branch
2 times, most recently
from
afa0b12 to
34a8a93
Compare
alextaing
force-pushed
the
dev/element-icons
branch
from
34a8a93 to
617e9f7
Compare
tmeyer2115
approved these changes
Sep 22, 2023
Merged
alextaing
added a commit
that referenced
this pull request
Sep 26, 2023
## Features - Layouts can now be added when adding a page. This new step is at the very end of the Add Page process (#376). - The Live Preview Button now opens up to the current active page instead the PageJS landing page (#379). ## Changes - Updated icons for Components, Containers, and Layouts (#378)! - The current selected viewport is now highlighted in the dropdown to keep track of the current viewport (#386). ## Fixes - The page settings now correctly refers to scope as "Content Scope" (#381). - Buggy deploy button behavior has been fixed (#385).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates element icons to the ones that product requested. This PR also consolidates the logic we used to decide what icon to render. SVGs sourced from https://fontawesome.com.
J-SLAP=2940
TEST=manual