Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main (v1.6.5) into develop #473

Merged
merged 10 commits into from
Feb 13, 2025

Conversation

github-actions[bot]
Copy link
Contributor

Merge main (v1.6.5) into develop

k-gerner and others added 7 commits September 19, 2024 15:30
### Changes
- Update version for search-headless-react to pick up CloudChoice changes
This PR adjusts our useId function, which generates ids for
html elements, to also take a 'basename' argument from
callers. This is to help reduce the likelihood of an id
made conflicting with an id somewhere else on the page.

J=WAT-4464
TEST=auto

Ran tests. Was having issues getting the test site running

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
**Fixes**

- Updates id generation to reduce risk of id collision #471
@github-actions github-actions bot requested a review from a team as a code owner October 17, 2024 20:31
Copy link
Contributor Author

Current unit coverage is 92.01741654571843%
Current visual coverage is 79.24701561065197%
Current combined coverage is 92.50483558994198%

@Fondryext Fondryext merged commit cda8277 into develop Feb 13, 2025
21 of 22 checks passed
@Fondryext Fondryext deleted the dev/merge-v1.6.5-76fb682-into-develop branch February 13, 2025 19:32
@coveralls
Copy link

coveralls commented Feb 13, 2025

Coverage Status

coverage: 85.227%. remained the same
when pulling 3e0a94b on dev/merge-v1.6.5-76fb682-into-develop
into 4be4110 on develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants