GDA: Dev/citations component override #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TEST=manual
J=CLIP-1369 TEST=manual|auto
J=CLIP-1369 TEST=manual|auto Ran `npm run test` and `npm run wcag` and did manual testing on test-site
J=CLIP-1369 TEST=manual|auto Ran `npm run test` and `npm run wcag` and did manual testing on test-site
|
Current unit coverage is 92.17687074829932% |
J=CLIP-1369 TEST=manual|auto Ran `npm run test` and `npm run wcag` and did manual testing on test-site
yen-tt
reviewed
Jul 24, 2024
J=CLIP-1369 TEST=manual|auto Ran `npm run test` and `npm run wcag` and did manual testing on test-site
yen-tt
reviewed
Jul 24, 2024
yen-tt
reviewed
Jul 24, 2024
J=CLIP-1369 TEST=manual|auto Ran `npm run test` and `npm run wcag` and did manual testing on test-site
nbramblett
approved these changes
Jul 24, 2024
yen-tt
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
CitationsContainerprop to<GenerativeDirectAnswer>to allow custom components to be passed inJ=CLIP-1369
TEST=manual|auto
Ran
npm run build,npm run test, andnpm run wcagand did manual testing on test-site