Added storybook stories for generative direct answer component #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J=CLIP-1226 TEST=manual ran `npm run storybook`
|
Current unit coverage is 92.12445308701993% |
EmilyZhang777
approved these changes
Jun 21, 2024
Fondryext
added a commit
that referenced
this pull request
Feb 20, 2025
This PR adds Generative Direct Answers (GDA) and GDA analytics. Full merge thread can be found below - many of the changes were already in main and were just merged into the develop branch while developing. * add generativeDirectAnswer support (#441) J=CLIP-1226 TEST=auto,manual added unit and visual regression test, ran and saw tests passed added GDA to test-site App and verified that the appropriate gda content shows up and the UI looks as expected * Added storybook stories for generative direct answer component (#442) J=CLIP-1226 TEST=manual ran `npm run storybook` * update search-headless-react dependencies version to 2.5.0-beta.3 (#443) New version has `queryDurationMillis` as an optional field of VerticalResults J=CLIP-1226 TEST=auto,manual ran `npm run test` temporarily added GDA to ProductsPage in test site and verified that the appropriate gda content shows up after a vertical search. * support clickable citation card with link (#444) J=CLIP-1332 TEST=auto,manual ran `npm run test` and test manually on test-site * GDA: citations component override (#451) Changes: - Added `CitationsContainer` prop to `<GenerativeDirectAnswer>` to allow custom components to be passed in - Updated test cases and test-site with new component passed through J=CLIP-1369 TEST=manual|auto Ran `npm run build`, `npm run test`, and `npm run wcag` and did manual testing on test-site * Check for search id before executing GDA (#454) J=CLIP-1461 TEST=auto,manual ran `npm run test` and tested manually on test-site to verified gda is executed as expected * Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check * increment versions * Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check * Update snapshots * decrement package * Function Vertical Support via search-core/headless upgrade (#459) This change upgrades the version for search-core and search-headless to catch the changes which add support for function verticals. It also adds a function vertical page to the test-site for easier testing. An image of that page is attached. J=WAT-3474 TEST=auto,manual Tested via test-site, saw responses returned were upper cased as expected by the plugin, and the source was FUNCTION_VERTICAL. <img width="1603" alt="Screenshot 2024-08-29 at 4 03 26 PM" src="https://github.com/user-attachments/assets/14e939eb-0ac3-493f-be83-44fdf9350358"> * do not display GDA citations without name field (#468) J=CLIP-1565 TEST=auto,manual added and ran jest test verfied locally using test-site that divider and citations section are not displayed without minimum citation data * Fix hook issues caused by citations rendering (#469) TEST=manual function as before on test-site. Verified it doesn't cause error in ALPHA * Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check * try remaking package locks * use develop package locks * Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check * Update snapshots * Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check * Update snapshots * Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check * Automated update to repo's documentation from github action * remake package locks * Add analytics event for Generative Direct Answer card (#486) * Add analytics event for Generative Direct Answer card J=WAT-4600,WAT-4604 TEST=auto,manual added unit test tested manually on test-site: - clicked on a citation and saw the citation click event logged in snowflake - hardcoded a link in the gda text, clicked on the link, saw cta click event logged in snowflake --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * try copying package lock * Upgrade versions to non-beta * Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check --------- Co-authored-by: sahilvaidya <[email protected]> Co-authored-by: anguyen-yext2 <[email protected]> Co-authored-by: Yen Truong <[email protected]> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
J=CLIP-1226
TEST=manual
ran
npm run storybook