Update wording on pure function definition. #2556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was originally going to put a PR to fix "has not side-effects", but I also re-read this sentence and realized it could be interpreted as saying a pure function returns its parameters, not a deterministic value based on its parameters.
WorldSEnder
approved these changes
Mar 27, 2022
|
Visit the preview URL for this PR (updated for commit 9b09ecc): https://yew-rs--pr2556-patch-1-em7rg858.web.app (expires Sun, 03 Apr 2022 16:10:30 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
ranile
approved these changes
Mar 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a typo in docs/concepts/pure-functions.mdx.
I was originally going to put a PR to fix only "has not side-effects", but I also re-read this sentence and realized it could be interpreted as saying a pure function returns its parameters exactly, not a deterministic value based on its parameters.
Checklist
cargo make pr-flowI am assuming the above are not required for docs-only changes, let me know if I am mistaken.