Format website with prettier #2536
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ranile
force-pushed
the
prettier-website
branch
from
7c10a99 to
97a3419
Compare
# Conflicts: # website/docs/concepts/html/classes.mdx # website/docs/concepts/html/components.mdx # website/docs/concepts/html/conditional-rendering.mdx # website/docs/concepts/html/elements.mdx # website/docs/concepts/html/events.mdx # website/docs/concepts/html/fragments.mdx # website/docs/concepts/html/introduction.mdx # website/docs/concepts/html/lists.mdx # website/docs/concepts/router.mdx
they're autogenerated and don't like being formatted
|
Visit the preview URL for this PR (updated for commit 3aeab7e): https://yew-rs--pr2536-prettier-website-jwy6xmk2.web.app (expires Sun, 10 Apr 2022 08:28:08 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
voidpumpkin
added
the
S-waiting-on-author
# Conflicts: # website/docs/concepts/function-components/hooks/introduction.mdx # website/package-lock.json # website/package.json # website/sidebars/docs.js
ranile
dismissed stale reviews from voidpumpkin and github-actions[bot]
via
8d110f7
# Conflicts: # website/docs/advanced-topics/server-side-rendering.md # website/docs/concepts/contexts.mdx # website/sidebars/docs.js
ranile
added
A-ci
| @@ -26,10 +27,19 @@ jobs: | |||
| with: | |||
| node-version: "16" | |||
|
|
|||
| - name: Check Translations | |||
| - name: Install dependencies | |||
There was a problem hiding this comment.
You probably wanted to revert this name change too, right?
There was a problem hiding this comment.
No, this job does everything: run prettier, check translations, build the site and upload the artifacts. That's why we need to install dependencies. I just made it a separate step (it was done in the check translations step previously)
There was a problem hiding this comment.
Ah, I totally missed what was going on here, sorry! I thought you renamed the entire job to "Install dependencies" :)
In my defence, it was very early in the morning :D
Description
Add prettier to format docs in website. I also experimented a little bit with eslint but it doesn't like the frontmatter in our mdx files
Fixes #2386
Checklist
cargo make pr-flow