Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert components concept docs from SC to FC #2434

Merged
merged 5 commits into from
Feb 7, 2022

Conversation

voidpumpkin
Copy link
Member

@voidpumpkin voidpumpkin commented Feb 4, 2022

Pre-note:
I am currently very sick and after a week i will be gone for a whole month, thus I need to merge this in quickly so you guys can iterate upon it or i can comeback to it when i am back. So give a look through, leave comments but ideally don't let them block the PR and add sub-tasks in #2312 instead.

Description

  • moved struct components to advanced topics
  • added docs about HOC for Suspense and Context
  • added a ease-in topic before components that introduces
    HTML/CSS/JS in yew
  • edit components concept to use function components

Checklist

  • I have run cargo make pr-flow
  • I have reviewed my own code
  • I have added tests

- moved struct components to advanced topics
- added docs about HOC for Suspense and Context
- added a ease-in topic before components that introduces
HTML/CSS/JS in yew
- edit components concept to use function components
github-actions[bot]
github-actions bot previously approved these changes Feb 4, 2022
@github-actions
Copy link

github-actions bot commented Feb 4, 2022

Visit the preview URL for this PR (updated for commit bdffdf8):

https://yew-rs--pr2434-doccu-man-htr7a0cv.web.app

(expires Fri, 11 Feb 2022 16:21:41 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

github-actions[bot]
github-actions bot previously approved these changes Feb 4, 2022
@voidpumpkin voidpumpkin requested review from ranile and siku2 February 4, 2022 13:14
@voidpumpkin voidpumpkin marked this pull request as ready for review February 4, 2022 13:14
@voidpumpkin
Copy link
Member Author

Merging, lets iterate any issues using other PR's

@voidpumpkin voidpumpkin merged commit 6366925 into yewstack:master Feb 7, 2022
@voidpumpkin voidpumpkin deleted the doccu-man branch February 7, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants