-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final documentation touch ups & tag 0.19.0 #2220
Conversation
Visit the preview URL for this PR (updated for commit 2eaf4d3): https://yew-rs--pr2220-touch-docs-908o6ntf.web.app (expires Mon, 06 Dec 2021 18:50:58 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Tried in the preview website, if you have closed the sidebar by clicking the logo on the upper left. There is no apparent way of bringing back the side menu. I tried a bit and found that clicking on the version button and the docs button actually brings out the sidebar. But they make the current page jump... (say if you are on "using trunk" page, clicking on "Docs" jumps you to introduction, and clicking on the version selector jumps you to "Build a sample app") In comparison, https://docusaurus.io/docs has buttons to exand and close the side bar Also the bot now needs to append |
@Madoshakalaka, I fixed the next redirect issue. Also, the docs button properly highlights now. The issue you're describing with not being able to show sidebar is different. The home page is now an actual page now instead of a docs redirect. You can navigate to docs page by clicking the docs button in the navbar. I think the issue here is that you're used to the old design and new one feels "wrong" |
@hamza1311 alright, sounds good |
now that home is its own page, docs should be under `/docs/`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, could we add the 0.19.0 tag at the top with this PR aswell?
Sure, I can add that but changing docs after that is gonna be inconvenient |
Why? I believe its possible to just add a version without copying all files, right? |
The command will create a copy of all the files and add a new version |
Hmm i guess we have no other option, we want to serve 0.19 as default when people come to the page |
But probably thats a diffrent PR then |
Well, I did it now. We can just roll with it. Instead of changing anything else, let's release now |
@hamza1311 Change the PR header then aswell |
@voidpumpkin done |
Description
Fix minor documentation issues and some pages
Checklist
cargo make pr-flow