Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docosaurus to v2 beta 9 #2215

Merged
merged 3 commits into from
Nov 29, 2021
Merged

Update docosaurus to v2 beta 9 #2215

merged 3 commits into from
Nov 29, 2021

Conversation

voidpumpkin
Copy link
Member

@voidpumpkin voidpumpkin commented Nov 28, 2021 •
edited
Loading

Description

  • Also fix tabs
  • Add toml language highlighting
  • move around introduction files

Checklist

  • I have run cargo make pr-flow
  • I have reviewed my own code
  • I have added tests

@voidpumpkin
Update docosaurus to v2 beta 9
d96db43 
- Also fix tabs
- Add toml language highlighting
@voidpumpkin voidpumpkin added documentation meta Repository chores and tasks labels Nov 28, 2021
@github-actions
Copy link

github-actions bot commented Nov 28, 2021 •
edited
Loading

Visit the preview URL for this PR (updated for commit 13144a7):

https://yew-rs--pr2215-update-docosaurus-v2-fjtoxqhz.web.app

(expires Sun, 05 Dec 2021 15:46:43 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@voidpumpkin voidpumpkin mentioned this pull request Nov 28, 2021
Merged
3 tasks
ranile
ranile approved these changes Nov 28, 2021
View reviewed changes
Copy link
Member

@ranile ranile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked around the site a little bit and it seems good. If something needs changing, we could always change it later.

mc1098
mc1098 approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@mc1098 mc1098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tabs look good 🤗

@ranile
Copy link
Member

ranile commented Nov 29, 2021

I'm going to merge this. Any fixes (if needed) can come in subsequent PRs

@ranile ranile merged commit 399a5e8 into yewstack:master Nov 29, 2021
@voidpumpkin voidpumpkin deleted the update-docosaurus-v2-beta-9 branch November 29, 2021 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mc1098 mc1098 mc1098 approved these changes

@ranile ranile ranile approved these changes

Assignees
No one assigned
Labels
documentation meta Repository chores and tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@voidpumpkin @ranile @mc1098