Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate 0.19 CHANGELOG.md #2199

Merged
merged 6 commits into from
Nov 29, 2021
Merged

generate 0.19 CHANGELOG.md #2199

merged 6 commits into from
Nov 29, 2021

Conversation

voidpumpkin
Copy link
Member

@voidpumpkin voidpumpkin commented Nov 25, 2021 •
edited
Loading

Description

  • auto generated changelog
  • make command to actually generate it
  • generate changelog per package

Checklist

  • I have run cargo make pr-flow
  • I have reviewed my own code
  • I have added tests

@voidpumpkin voidpumpkin added the meta Repository chores and tasks label Nov 25, 2021
@voidpumpkin voidpumpkin changed the title generate 0.19 CAHNGELOG.md generate 0.19 CHANGELOG.md Nov 25, 2021
@voidpumpkin
Copy link
Member Author

voidpumpkin commented Nov 26, 2021 •
edited
Loading

Needs to be updated because merged PR's: #2192 #2200

@voidpumpkin
Copy link
Member Author

I have edited the helper to generate change log per given package name by utilizing labels
The change log should look a bit better now

@voidpumpkin voidpumpkin mentioned this pull request Nov 27, 2021
Closed
18 tasks
@mc1098
Copy link
Contributor

mc1098 commented Nov 27, 2021

Are you going to merge the CHANGELOG from the yew-router directory as it seems like this is going to be a single CHANGELOG for the whole mono repo.

@voidpumpkin
Copy link
Member Author

Are you going to merge the CHANGELOG from the yew-router directory as it seems like this is going to be a single CHANGELOG for the whole mono repo.

I was not aware of that, let me look...

@voidpumpkin
Copy link
Member Author

Yeah i guess i can merge it in

@voidpumpkin
Copy link
Member Author

@mc1098 done

@mc1098
Copy link
Contributor

mc1098 commented Nov 27, 2021

I was not aware of that, let me look...

@voidpumpkin I missed it too when I was messing with the CHANGELOG before 😅.

mc1098
mc1098 reviewed Nov 27, 2021
View reviewed changes
Copy link
Contributor

@mc1098 mc1098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the missing version numbers :)

mc1098
mc1098 previously approved these changes Nov 27, 2021
View reviewed changes
mc1098
mc1098 previously approved these changes Nov 27, 2021
View reviewed changes
ranile
ranile reviewed Nov 28, 2021
View reviewed changes
@voidpumpkin
Copy link
Member Author

@mc1098 @hamza1311 I think we could merge this in, no open questions and if anything comes up we can create separate PR's

@ranile
Copy link
Member

ranile commented Nov 29, 2021

Sure, we won't be adding more features anyway

ranile
ranile approved these changes Nov 29, 2021
View reviewed changes
Copy link
Member

@ranile ranile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're feature complete for this release

@mc1098 mc1098 merged commit 4875430 into yewstack:master Nov 29, 2021
@voidpumpkin voidpumpkin deleted the change-me-baby branch November 29, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mc1098 mc1098 mc1098 approved these changes

@ranile ranile ranile approved these changes

Assignees
No one assigned
Labels
meta Repository chores and tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@voidpumpkin @mc1098 @ranile