Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "struct update" syntax to pass props to component (..props instead of with props) #2024

Merged
merged 24 commits into from
Sep 6, 2021
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
9759c39
Reword to use double-dot syntax instead of "with"
Xavientois Aug 29, 2021
ca7479b
Implement double-dot syntax for props in components
Xavientois Aug 30, 2021
2b53e00
Update documentation with new syntax
Xavientois Aug 30, 2021
3bc1def
Update forgotten doc
Xavientois Aug 30, 2021
102ccaf
Merge branch 'master' into add-double-dot-prop-syntax
Xavientois Aug 30, 2021
afc22d0
Add descriptive comments
Xavientois Aug 30, 2021
de0c69a
Merge branch 'add-double-dot-prop-syntax' of github.com:Xavientois/ye…
Xavientois Aug 30, 2021
db2598f
Check props and base expression
Xavientois Aug 30, 2021
503ef88
Make compatible with 1.49.0 by removing then
Xavientois Aug 30, 2021
aa94eff
Fix website tests
Xavientois Aug 30, 2021
04c90de
Update error output
Xavientois Aug 30, 2021
e2ef587
Implicitly convert string literals to String if they are listed as props
Xavientois Aug 30, 2021
6f9ea0f
Remove unused keyword
Xavientois Aug 30, 2021
920daf3
Rename function for checking if string literal
Xavientois Aug 30, 2021
dc43274
Fix weird formatting
Xavientois Aug 30, 2021
b7a312b
Update code based on review
Xavientois Aug 31, 2021
e78cb2a
Update website/docs/concepts/html/components.md
Xavientois Aug 31, 2021
0922b19
Base expression span includes dot2 now
Xavientois Sep 1, 2021
aba0cdc
Improve specificity of error message
Xavientois Sep 1, 2021
7ab9719
Chain together error messages
Xavientois Sep 1, 2021
e79ea1d
Add an example failure case to illustrate combined error message
Xavientois Sep 1, 2021
b75e16a
Update based on review comments
Xavientois Sep 4, 2021
d68826e
Merge branch 'master' into add-double-dot-prop-syntax
Xavientois Sep 5, 2021
79599d9
Fix missing clones
Xavientois Sep 6, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unused keyword
  • Loading branch information
Xavientois committed Aug 30, 2021
commit 6f9ea0fef4fe60fdf7a414dff4d3b3fa63f1fc9a
4 changes: 0 additions & 4 deletions packages/yew-macro/src/props/component.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@ use syn::{
Expr, ExprLit, Lit,
};

mod kw {
syn::custom_keyword!(with);
}

pub struct ComponentProps {
props: Props,
base_expr: Option<Expr>,
Expand Down