Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add yew-validation crate #1376

Merged
merged 5 commits into from
Aug 15, 2020
Merged

Add yew-validation crate #1376

merged 5 commits into from
Aug 15, 2020

Conversation

philip-peterson
Copy link
Contributor

@philip-peterson philip-peterson commented Jul 4, 2020 •
edited
Loading

Description

This relates to PR #1344 and is the separation of the validation logic out of it into its own crate.

Checklist:

  • I have run ./ci/run_stable_checks.sh
  • I have reviewed my own code
  • I have added tests

@teymour-aldridge
Copy link
Contributor

Would be useful to add the tests for this to the CI.

@philip-peterson
Copy link
Contributor Author

Would be useful to add the tests for this to the CI.

Strange, could've sworn I had added those.. oh well, pushed!

@philip-peterson philip-peterson mentioned this pull request Jul 4, 2020
Closed
3 tasks
@jstarry
Copy link
Member

jstarry commented Jul 8, 2020

@philip-peterson maybe we can have this live outside of Yew since it will be useful for other projects and is not yew specific?

@philip-peterson
Copy link
Contributor Author

I suppose we could, I suspect this crate will be deleted as soon as #1269 is solved though which I definitely think we can get done quickly. Reason I would prefer to keep this in Yew is that based on the PR comments I received it got taken in a direction I wouldn't want it to be as a standalone crate; I did create the public taginfo crate but it behaves contrary to the PR changes that were requested.

@philip-peterson
Copy link
Contributor Author

Alternatively we could solve #1269 first and then this crate won't be necessary.

@jstarry
Copy link
Member

jstarry commented Aug 15, 2020

Let's merge this for now and we can remove later if #1269 makes this obsolete

@jstarry jstarry merged commit 17fa773 into yewstack:master Aug 15, 2020
jstarry pushed a commit that referenced this pull request Aug 16, 2020
@philip-peterson @jstarry
Add yew-validation crate (#1376)
191c6b2 
* Add yew-validation crate

* Update description

* add test to run-tests.sh
teymour-aldridge pushed a commit to teymour-aldridge/yew that referenced this pull request Sep 1, 2020
@philip-peterson @teymour-aldridge
Add yew-validation crate (yewstack#1376)
38ba919 
* Add yew-validation crate

* Update description

* add test to run-tests.sh
teymour-aldridge pushed a commit to teymour-aldridge/yew that referenced this pull request Sep 1, 2020
@philip-peterson @teymour-aldridge
Add yew-validation crate (yewstack#1376)
c07022a 
* Add yew-validation crate

* Update description

* add test to run-tests.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philip-peterson @teymour-aldridge @jstarry