Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StartsRequestTest.java:60-61: Add a test for case... #633

Closed
alex-palevsky opened this issue Oct 29, 2014 · 13 comments
Closed

StartsRequestTest.java:60-61: Add a test for case... #633

alex-palevsky opened this issue Oct 29, 2014 · 13 comments

Comments

@alex-palevsky
Copy link
Contributor

Puzzle 594-7fd8c4ec in src/test/java/com/rultor/agents/req/StartsRequestTest.java:60-61 has to be resolved: Add a test for case where dockerfile is specified instead of image in configuration (docker: directory some/directory).
@alex-palevsky
Copy link
Contributor Author

@yegor256 please proceed, it's yours

@yegor256
Copy link
Owner

@alex-palevsky please assign @krzyk to this task

@alex-palevsky
Copy link
Contributor Author

@alex-palevsky please assign @krzyk to this task

@yegor256 yes, done, @krzyk is at the task, please start! whoever worked with this task before, please stop immediately

krzyk pushed a commit to krzyk/rultor that referenced this issue Nov 9, 2014
yegor256#633 added test for dockerfile
322f460
@alex-palevsky
Copy link
Contributor Author

@krzyk you're holding this task for 10 days already

@alex-palevsky alex-palevsky mentioned this issue Nov 10, 2014
Closed
@alex-palevsky
Copy link
Contributor Author

these puzzles in progress: 633-705a6074

@alex-palevsky
Copy link
Contributor Author

these puzzles in progress: 633-705a6074/#648

@alex-palevsky
Copy link
Contributor Author

Thanks all, I'm closing

@alex-palevsky
Copy link
Contributor Author

I don't see any messages from @krzyk above, not sure if there was actual contribution (correct me if I'm wrong)

@krzyk
Copy link

krzyk commented Nov 12, 2014

@alex-palevsky PR #644

@yegor256
Copy link
Owner

@alex-palevsky looks like it's a mistake, please add extra 30 mins to @krzyk

@alex-palevsky
Copy link
Contributor Author

@alex-palevsky looks like it's a mistake, please add extra 30 mins to @krzyk

@yegor256 30 mins extra was just paid to @krzyk, transaction 47454781

@caarlos0 caarlos0 mentioned this issue Dec 2, 2014
Merged
@caarlos0
Copy link
Contributor

caarlos0 commented Dec 3, 2014

@alex-palevsky done.

@alex-palevsky
Copy link
Contributor Author

the last puzzle 633-705a6074/#648 solved

0pdd referenced this issue Oct 27, 2017
@tannakartikey @rultor
#1195 added Postgres configuration in Dockerfile
8f1d38f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@krzyk @caarlos0 @yegor256 @alex-palevsky