Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override default ping settings #5

Merged
merged 2 commits into from
Dec 26, 2023
Merged

Override default ping settings #5

merged 2 commits into from
Dec 26, 2023

Conversation

eugishch
Copy link

Primary goals:

  1. Sometimes you need to check access to a specific web resource.
  2. If the resource is unavailable or takes a long time to respond, then the test should not be run.
  3. Sometimes it is necessary to run a test in case of offline.

For this goal add WeAreOnlineOverride annotation which allows to override default ping address and set connect/read timeout

Add WeAreOnlineOverride annotation that override default ping address and set connect/read timeout
@yegor256
Copy link
Owner

@eugishch thanks for your contribution! Please, run mvn clean install -Pqulice, you will see problems. Also, I believe, it would be better to name it @OnlineMeans. With this name the annotation will explain: what "online" means, technically speaking. WDYT?

Rename annotation WeAreOnlineOverride to OnlineMeans. With this name the annotation will explain: what "online" means, technically speaking.

Add junit-platform-commons to dependencies for correct annotation search (include inheritance, etc)
@yegor256
Copy link
Owner

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Dec 26, 2023

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit c08546c into yegor256:master Dec 26, 2023
@rultor
Copy link
Collaborator

rultor commented Dec 26, 2023

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 2min)

@yegor256
Copy link
Owner

@rultor release, tag is 0.0.2

@rultor
Copy link
Collaborator

rultor commented Dec 26, 2023

@rultor release, tag is 0.0.2

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Collaborator

rultor commented Dec 26, 2023

@rultor release, tag is 0.0.2

@yegor256 Done! FYI, the full log is here (took me 6min)

@yegor256
Copy link
Owner

@eugishch thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants