Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update name #101

Merged
merged 1 commit into from
Sep 12, 2024
Merged

feat: update name #101

merged 1 commit into from
Sep 12, 2024

Conversation

Schlagonia
Copy link
Collaborator

Description

Allow management to update the strategy name

Fixes # (issue)

Checklist

  • I have run solidity linting
  • I have run the tests on my machine
  • I have followed commitlint guidelines
  • I have rebased my changes to the latest version of the main branch
  • I have updated the SPECIFICATION.md for any relevant changes

Copy link
Collaborator

@fp-crypto fp-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why no setSymbol?

@Schlagonia
Copy link
Collaborator Author

Why no setSymbol?

symbol is dynamically returned and not a storage variable

@Schlagonia Schlagonia changed the base branch from master to 3_0_3 September 9, 2024 21:17
@Schlagonia Schlagonia merged commit 79d1fc5 into 3_0_3 Sep 12, 2024
3 checks passed
@Schlagonia Schlagonia deleted the update_name branch September 12, 2024 23:16
Schlagonia added a commit that referenced this pull request Sep 24, 2024
* chore: bump api version

* test: fix invariant test

* feat: max deposit (#99)

* feat: max uint deposit

* fix: invariant test

* fix: rebase

* fix: dont max mint

* fix: uint 256

Co-authored-by: FP <[email protected]>

* fix: uint 256

Co-authored-by: FP <[email protected]>

* test: check balances

---------

Co-authored-by: FP <[email protected]>

* chore: add statemind audit

* chore: match abis (#100)

* feat: update name (#101)

* chore: update domain separator (#102)

* chore: update domain seperator

* feat: dont cache domain

* chore: test runs

* fix: comment

Co-authored-by: spalen0 <[email protected]>

* fix: comment

Co-authored-by: spalen0 <[email protected]>

* fix: permit cast (#104)

* fix: deposit flow (#103)

* fix: conversion

* test: full loss

* feat: add self check to max views

* test: balance check

* fix: spelling

* chore: deployed

---------

Co-authored-by: FP <[email protected]>
Co-authored-by: spalen0 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants