[READY] Exclude psutil 5.0.1 from test requirements #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psutil 5.0.1 is broken on Python 3.6 and Windows 64-bit.
Current coverage is 92.76% (diff: 100%)@@ master #695 diff @@
==========================================
Files 79 79
Lines 5269 5269
Methods 297 297
Messages 0 0
Branches 139 139
==========================================
Hits 4888 4888
Misses 326 326
Partials 55 55
|
|
Thanks! LGTM |
|
Reviewed 1 of 1 files at r1. Comments from Reviewable |
|
📌 Commit 5fecb72 has been approved by |
|
⚡ Test exempted - status |
homu
added a commit
that referenced
this pull request
Jan 22, 2017
[READY] Exclude psutil 5.0.1 from test requirements Last version of psutil (5.0.1) is broken on Python 3.6 and Windows 64-bit. See issue giampaolo/psutil#951. We exclude it from our test requirements. This fixes the builds with `arch=64` and `python=36` on AppVeyor. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/695) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last version of psutil (5.0.1) is broken on Python 3.6 and Windows 64-bit. See issue giampaolo/psutil#951. We exclude it from our test requirements. This fixes the builds with
arch=64andpython=36on AppVeyor.This change is