Fix: Ignoring time interval on DefaultLocationProvider #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yayaa
commented
Jan 3, 2021
| if (getConfiguration().keepTracking()) { | ||
| requestUpdateLocation(getConfiguration().defaultProviderConfiguration().requiredTimeInterval(), | ||
| getConfiguration().defaultProviderConfiguration().requiredDistanceInterval(), false); | ||
| if (!getConfiguration().keepTracking()) { |
There was a problem hiding this comment.
Existing logic was to request as 0 time and distance interval to receive an immediate update, and then remove location request once any location is received and register a new update request with the intervals from configuration.
But since, provider returns a new location for every update request and then wait for the interval, this ended up ignoring the interval completely.
So, the fix is to remove if only keepTracking is false instead of removing by default and registering new requests if true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #116