Fix: Showing Settings dialog multiple times #117
Conversation
| // not getSourceProvider, because we don't want to connect if it is not already attempt | ||
| if (!settingsDialogIsOn && googlePlayServicesLocationSource != null && | ||
| (isWaiting() || getConfiguration().keepTracking())) { | ||
| onConnected(); |
There was a problem hiding this comment.
onResume was used to keep the GoogleClient connection on, but since now that is taken care of by FusedLocationProviderClient directly, responsibility here is changed to request a location update so that is guaranteed that location provider client will be connected to this listener.
Requesting a location update multiple times will only replace the existing request, so it is safe to use it for keeping connection here. Any other action onResume can cause multiple calls. For example; Calling LocationManager.getLocation in Activity.onCreate will trigger get call and after onCreate, onResume will be triggered by the system. So, that is why, onResume should only re-attach listeners or re-connect clients nothing more.
Follow up on: #107
Fixes: #115