Support Sprockets 4 #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yasaichi
force-pushed
the
support-sprockets4
branch
7 times, most recently
from
479a83a to
2e80313
Compare
yasaichi
commented
Mar 11, 2017
| diff = | ||
| case major_version_of(Sprockets) | ||
| when 2 | ||
| { extensions.first => engine } |
There was a problem hiding this comment.
[IMO]
You should use better way to specify the extension filter logic on this line.
yasaichi
force-pushed
the
support-sprockets4
branch
from
2e80313 to
ac143c2
Compare
yasaichi
force-pushed
the
support-sprockets4
branch
8 times, most recently
from
c5b300e to
1010bb7
Compare
Because the latest version of slim-rails has the following bugs: * slim-template/slim-rails#135 * slim-template/slim-rails#136
Because the latest version of slim-rails has the following bugs: * slim-template/slim-rails#135 * slim-template/slim-rails#136
yasaichi
force-pushed
the
support-sprockets4
branch
from
1010bb7 to
6b7bc3d
Compare
yasaichi
force-pushed
the
support-sprockets4
branch
from
6b7bc3d to
ce21773
Compare
yasaichi
force-pushed
the
support-sprockets4
branch
from
ce21773 to
0b1e437
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[NOTE] Related to #10.
This PR adds support of Sprockets 4 by modifying
EngineRegistrarmainly.It also adds the upper version limit of slim-rails to avoid the following bugs: