Handle NPM_CONFIG_GLOBALCONFIG when present #7604
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we please get this PR reviewed? It's solving a very real config bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request is to address issue #5543
I hope it helps! Any feedback to improve the code is welcome.
Also, I am not sure if this helps resolve #4451 as well.
Test plan
node_modules/jest/bin/jest.js -i __tests__/registries/npm-registry.js/tmp/customrcwith the contentANSWER=42yarn buildNPM_CONFIG_GLOBALCONFIG=/tmp/customrc ./bin/yarn config get ANSWER42as expected.