-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Npm offline mirror support #60
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
} | ||
} | ||
if (this.config['kpm-offline-mirror']) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double quotes
Known issues:
|
👍 PR looks good. Only comments would be on that the code style is a bit different to the one that's used but that doesn't really matter much. |
Thanks, I'll match the style, please comment where I missed it |
I'll run make lint |
👍 Woot, awesome! Looks good, merge at will! |
arcanis
added a commit
that referenced
this pull request
Sep 13, 2018
Uses symlinks instead of a script for bin indirection to allow callin…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
t11037039: Integrate kpm with React Native
Offline support mode in kpm as a seamless layer for npm install / tarball download.
The idea is that npm tarballs can be configured per project and checked in fbsource (or some offline file sharing service) and no internet connection will be required to restore node_modules.
How it works:
http://
they are copied to "kpm-offline-mirror" folder and fbkpm.lock saves the path to file in mirror rather than remote urlExample