Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yarn create doesn't appear to pass parameters #4670

Closed
jpdriver opened this issue Oct 10, 2017 · 1 comment
Closed

yarn create doesn't appear to pass parameters #4670

jpdriver opened this issue Oct 10, 2017 · 1 comment

Comments

@jpdriver
Copy link

Do you want to request a feature or report a bug?

Bug

What is the current behavior?

Parameters do not appear to be passed through when using yarn create

  • using create-react-app my-app --scripts-version custom-react-scripts

screen shot 2017-10-10 at 9 35 04 am

  • using yarn create react-app my-app --scripts-version custom-react-scripts

screen shot 2017-10-10 at 9 26 50 am

If the current behavior is a bug, please provide the steps to reproduce.

  • Run a yarn create ... command that includes parameters e.g. --scripts-version above

What is the expected behavior?

  • running yarn create ... and running create-... using the globally installed package should produce the same output

Please mention your node.js, yarn and operating system version.

Software Version
NodeJS 7.10.1
Yarn 1.2.0
macOS 10.12.6
@JimmyLv
Copy link

JimmyLv commented Oct 11, 2017

Yep, I think actually it's quite easy to support this feature, please add it as soon as possible. ::D

@g-plane g-plane mentioned this issue Oct 14, 2017
Merged
@BYK BYK closed this as completed in #4713 Oct 16, 2017
BYK pushed a commit that referenced this issue Oct 16, 2017
@g-plane @BYK
fix(create): Fix passing parameters for "yarn create" (#4713)
26266c4 
**Summary**
Fixes #4670 .

**Test plan**

Manual verification.
![image](https://user-images.githubusercontent.com/17216317/31580316-5c29f296-b17e-11e7-9a6f-ba87294ee200.png)
joaolucasl pushed a commit to joaolucasl/yarn that referenced this issue Oct 27, 2017
@g-plane @joaolucasl
fix(create): Fix passing parameters for "yarn create" (yarnpkg#4713)
73a8070 
**Summary**
Fixes yarnpkg#4670 .

**Test plan**

Manual verification.
![image](https://user-images.githubusercontent.com/17216317/31580316-5c29f296-b17e-11e7-9a6f-ba87294ee200.png)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpdriver @JimmyLv