Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(e2e): use Node.js v20 for angular pnp test #6085

Merged
merged 1 commit into from
Jan 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
ci(e2e): use Node.js v20 for angular test
  • Loading branch information
merceyz committed Jan 15, 2024
commit e93afd3e4c727481f5069ecad989c566e5f706aa
6 changes: 5 additions & 1 deletion .github/actions/prepare/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,17 @@ inputs:
description: 'Whether to minify the bundle'
required: false
default: 'false'
node-version:
description: 'The version of Node.js to use'
required: false
default: 'current'

runs:
using: composite
steps:
- uses: actions/setup-node@v4
with:
node-version: current
node-version: ${{ inputs.node-version }}

#region Build the standard bundle
- uses: actions/cache@v3
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/e2e-pnp-angular-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ jobs:
- uses: actions/checkout@v3

- uses: ./.github/actions/prepare
with:
# TODO: Remove when the issue causing timeouts / crashes in Node.js >= 21 is fixed.
node-version: 20

- name: 'Running the integration test'
run: |
Expand Down
Loading