Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Svelte Language Server PnP Configuration #5953

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Update Svelte Language Server PnP Configuration #5953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .yarn/versions/ddf3a56f.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
releases:
"@yarnpkg/sdks": minor
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I chose this as a minor release because yarn dlx @yarnpkg/sdks vscode theoretically has to be rerun for packages that use svelte-language-tools. This makes it feel like more than a bugfix, however it's still "backwards compatible" because this should only be needed to fix broken projects so it's not a major breaking change either.

Let me know if the versioning isn't supposed to work that way!

1 change: 1 addition & 0 deletions packages/yarnpkg-sdks/sources/sdks/vscode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ export const generateSvelteLanguageServerWrapper: GenerateIntegrationWrapper = a
`bin/server.js` as PortablePath,
),
),
[`svelte.language-server.runtime-args`]: [`--loader`, `./.pnp.loader.mjs`],
});

await addVSCodeWorkspaceConfiguration(pnpApi, VSCodeConfiguration.extensions, {
Expand Down