Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arm64 to example supported cpu values #5756

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Add arm64 to example supported cpu values #5756

merged 2 commits into from
Sep 27, 2023

Conversation

MasterOdin
Copy link
Contributor

What's the problem this PR addresses?

PR adds arm64 to the list of example architectures for the CPU for the .yarnrc config file. I added this given that it's probably one of the most popular things people might add to this field given the existence of the Apple M1/M2 machines, and that I originally stumbled onto this field about just that, and the clickthrough to the node docs was unnecessary if the docs just listed this field. There is precedent in having the arm64 field listed in the example per the manifest.json file:

"cpu": {
"title": "Set of CPU architectures on which this package works.",
"description": "The value of `process.arch()` will be compared at install-time against this set. Should no matches be found, any postinstall script the package define will be skipped. If the package was exclusively depended upon via `optionalDependencies` entries, the package won't be installed at all.",
"type": "array",
"items": {
"type": "string"
},
"exampleItems": ["x64", "ia32", "arm64"]
},

How did you fix it?

By adding arm64 to the list of supported CPU architectures.

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@arcanis arcanis merged commit 4a6f932 into yarnpkg:master Sep 27, 2023
@arcanis
Copy link
Member

arcanis commented Sep 27, 2023

Looks reasonable, thanks!

@MasterOdin MasterOdin deleted the patch-1 branch September 27, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants