Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes types for @types/node 18.17 #5731

Merged
merged 7 commits into from
Sep 13, 2023
Merged

Fixes types for @types/node 18.17 #5731

merged 7 commits into from
Sep 13, 2023

Conversation

arcanis
Copy link
Member

@arcanis arcanis commented Sep 12, 2023 •
edited
Loading

What's the problem this PR addresses?

DefinitelyTyped/DefinitelyTyped#66405 added support for the path property to fs.Dirent; this revealed a couple of errors in our types.

Fixes #5728

How did you fix it?

  • Replaces Exclude<fs.Stats, 'name'> by Omit<fs.Stats, 'name'>
  • Replaces fs.Stats by Stats in the nm linker

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@arcanis arcanis merged commit ca6a3d6 into master Sep 13, 2023
@arcanis arcanis deleted the mael/types-node-fix branch September 13, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@arcanis