Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(builder): make bundle executable #5609

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Conversation

paul-soporan
Copy link
Member

What's the problem this PR addresses?

The builder doesn't make the bundle executable, which means that it can't be spawned directly without node.

I noticed this while testing the yarn bench script in our repo, which symlinks the bundle and then tries to spawn it without first chmod-ing it.

I decided that it makes sense for the builder to chmod it directly.

How did you fix it?

Made the builder chmod it.

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@paul-soporan paul-soporan added this pull request to the merge queue Jul 25, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 25, 2023
@paul-soporan paul-soporan added this pull request to the merge queue Jul 25, 2023
Merged via the queue into master with commit 1ccbcfb Jul 25, 2023
@paul-soporan paul-soporan deleted the paul/feat/chmod-bundle branch July 25, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants