feat(builder): make bundle executable #5609
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
The builder doesn't make the bundle executable, which means that it can't be spawned directly without node.
I noticed this while testing the
yarn bench
script in our repo, which symlinks the bundle and then tries to spawn it without firstchmod
-ing it.I decided that it makes sense for the builder to chmod it directly.
How did you fix it?
Made the builder
chmod
it.Checklist