perf: use fast-glob
instead of globby
#5606
Merged
+46
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
globby
is built on top offast-glob
(which we already use in@yarnpkg/shell
), but the only useful feature it adds for us isexpandDirectories
which has been broken for 3 years so we can't use it anyways.In addition,
globby
is maintained by a person that handles reasonable criticism by blocking our lead maintainer on both Twitter and GitHub, which makes it harder than necessary to communicate ¯\(ツ)/¯.How did you fix it?
Replaced
globby
withfast-glob
.Bundle size:
2730152 bytes
2720218 bytes
0.36%
Benchmarks:
Checklist