Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: convert gatsby portal dependencies into workspaces #5499

Merged
merged 4 commits into from
Jun 16, 2023

Conversation

paul-soporan
Copy link
Member

What's the problem this PR addresses?

@yarnpkg/gatsby depends on various packages from our monorepo using the portal: protocol.

This causes Yarn to treat them as external projects instead of workspaces, bypassing various workspace-related features including enforcing constraints.

In addition, gatsby-plugin-yarn-introspection depends on @yarnpkg/monorepo using the workspace: protocol, which is weird and unintended (and should be unsupported) given the fact that they are part of 2 different projects.

(Spoiler: I'm also working on a change that will make this behavior unsupported.)

While things work in practice, semantically it makes more sense to declare them as workspaces and use the workspace: protocol.

How did you fix it?

Turned them into workspaces.

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@arcanis arcanis merged commit 0509f16 into master Jun 16, 2023
@arcanis arcanis deleted the paul/chore/gatsby-workspaces branch June 16, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants