-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix npm tag resolver when dedupe #5497
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, could you add a test to https://github.com/yarnpkg/berry/blob/1860cf48865b515a783e5ad48e34a059a120d2fc/packages/acceptance-tests/pkg-tests-specs/sources/commands/dedupe.test.ts?
@merceyz added test |
750e5de
to
f7b84e3
Compare
Can we merge while it's fresh? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM though I see some of the other resolvers are also using this.getCandidates
so @arcanis could you take a look as well?
Any update? |
I think it'd make sense to use |
What's the problem this PR addresses?
Fixes
Registry failed to return tag "8.4.1"
when runningyarn dedupe
If I add
console.log(descriptor, locator.reference)
it logs
I guess it's self explanatory
...
How did you fix it?
Uses Semver resolver instead of tag resolver
...
Checklist