-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugin-essentials): upgrade all packages with wildcard #5381
Conversation
.yarn/versions/0e4a4eac.yml
Outdated
"@yarnpkg/cli": minor | ||
"@yarnpkg/plugin-essentials": minor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change so these need to be marked as major
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think all of these should be major
changes? Technically this could also be thought as a breaking change for the CLI, although only for interactive mode, which users review manually anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I marked this one as a major
version bump. I left other ones intact. I also declined some other version bumps. I have no clue if this is correct since I don't know the inter-dependencies between these packages. Feel free to update this file yourself or let me know how it should be configured.
Add support for upgrading both scoped and unscoped packages with `yarn up -i '*'`. It used to upgrade only unscoped packages. This change only affects interactive mode, so as not to change the existing behavior of `yarn up '*'`. Fixes #3550
I removed the integration test that I added since this change only affects interactive mode ( |
I added back the code that makes |
What's the problem this PR addresses?
yarn up '*'
only upgraded unscoped packages. I had to remember to runyarn up '*/*'
later to also upgrade scoped packages. I was running these commands with the-i
flag.This PR changes it so
yarn up -i '*'
upgrades both scoped and unscoped packages.Closes #3550
How did you fix it?
Use the
basename
micromatch
option so*
matches scoped (e.g.@types/node
) and unscoped (e.g.react
) packages.Checklist
I have set the packages that need to be released for my changes to be effective.
Although I am not sure I did it right.