Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
It's difficult to use JS constraints because they're not covered by types.
The automatic constraints check occurs before install; this has a couple of critical issues:
yarn add
, Yarn will request to callyarn constraints
for details but won't persist the changes on disk. As a result,yarn constraints
will remain silent.yarn add
/yarn up
changes aren't persisted on disk).yarn.config.js
file callrequire('./.pnp.cjs')
(a bit experimental at the moment, but why not), it causes problems during merge conflict resolution (the merge conflicts in the.pnp.cjs
file aren't resolved until after the install finishes).How did you fix it?
Created a types package
@yarnpkg/types
- it's meant to only contain "dumb" types, and only contains the constraints context at the moment. Later on, I plan to expand it to also cover plugins, but that'll be a separate project.The automated constraints checks will now occur after install rather than before.
Checklist