Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compat): update patch for [email protected] #5296

Merged
merged 2 commits into from
Mar 4, 2023

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Feb 26, 2023

What's the problem this PR addresses?

The PnP compatibility patch for TypeScript doesn't apply to [email protected].

Ref microsoft/TypeScript#35206

How did you fix it?

Rebased #5210 onto the 5.0.1-rc release.

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@merceyz merceyz marked this pull request as ready for review March 2, 2023 08:18
@arcanis arcanis merged commit 46c6949 into master Mar 4, 2023
@arcanis arcanis deleted the merceyz/fix/typescript-50-rc branch March 4, 2023 09:15
merceyz added a commit that referenced this pull request Mar 4, 2023
@chentsulin
Copy link

@merceyz Is there any plan to port this patch back to v3 release?

@merceyz
Copy link
Member Author

merceyz commented Mar 14, 2023

I've already backported it, it's the commit you can see above your comment, and prepared the next release, it's waiting on @arcanis to have time to create the release.

@chentsulin
Copy link

@arcanis TS 5 will be released at 3/16 (very soon). Good to see if it works with Yarn 3.

microsoft/TypeScript#51362

@wegry
Copy link

wegry commented Mar 16, 2023

TS 5 has been released. microsoft/TypeScript#51362 (comment)

@merceyz
Copy link
Member Author

merceyz commented Mar 16, 2023

Yarn v3.5.0 has been released

yarn set version berry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants